Improve onedarker theme contrast cursorline/selection
#12833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cc @nuid64 what do you think? |
onedarker theme contrast cursorline/selection (#12579)onedarker theme contrast cursorline/selection
|
Nice improvement. I think also changing ui.selection.bg to black is a sensible thing to do taking in account that it is now reversed. |
…itor#12579) Previously `ui.cursorline.primary` (`light-black`)/`ui.selection.primary` (`gray`) and `ui.selection` (`light-gray`)/`comment` (`light-gray`) had little or no contrast. `ui.cursorline.primary` is changed to a new darker color, `dark-black` and `ui.selection` is set to use `reversed`.
e5526cb to
6873a69
Compare
Done! |
Support for the key was recently added in helix-editor#12205 and helix-editor#12295. Not all themes were updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ui.cursorline.primary(
light-black)/ui.selection.primary(gray) andui.selection(light-gray)/comment(light-gray) had little or no contrast.ui.cursorline.primaryis changed to a new darker color,dark-blackandui.selectionis set to usereversed.After playing with the example solution in #12579 I decided to go with one that keeps the gray hue for selections and only requires adding one new color to the palette. The change also supports 256-color mode.
24-bit color:
256-color:
