Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: surprising behaviour when changing line above a comment #12575

Merged
merged 7 commits into from
Jan 17, 2025
Merged

fix: surprising behaviour when changing line above a comment #12575

merged 7 commits into from
Jan 17, 2025

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Jan 17, 2025

Fixes #12570

@nik-rev nik-rev marked this pull request as ready for review January 17, 2025 15:03
This was referenced Jan 17, 2025
Closed
Merged
Closed
the-mikedavis
the-mikedavis reviewed Jan 17, 2025
View reviewed changes
@the-mikedavis the-mikedavis added the A-command Area: Commands label Jan 17, 2025
@nik-rev nik-rev requested a review from the-mikedavis January 17, 2025 15:13
@nik-rev nik-rev marked this pull request as draft January 17, 2025 15:14
@nik-rev nik-rev marked this pull request as ready for review January 17, 2025 15:16
@the-mikedavis
minor: naming for the enum
a382bb0 
I like this better :P
@the-mikedavis
style: pull more bindings out of change_by_selection closure
a6df035 
This now makes `open` closer to `insert_newline` and should slightly
reduce the work done per-selection in the
`Transaction::change_by_selection` closure.
the-mikedavis
the-mikedavis approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, well spotted on this bug! I pushed some minor style changes

@the-mikedavis the-mikedavis merged commit 076d8bd into helix-editor:master Jan 17, 2025
6 checks passed
@nik-rev nik-rev deleted the fix/adds-comment-token branch January 17, 2025 21:59
mmibbetson pushed a commit to mmibbetson/helix that referenced this pull request Jan 18, 2025
@nik-rev @mmibbetson
fix: surprising behaviour when changing line above a comment (helix-e…
0da6657 
…ditor#12575)

Co-authored-by: Nikita Revenco <154856872+NikitaRevenco@users.noreply.github.com>
rmburg pushed a commit to rmburg/helix that referenced this pull request Jan 20, 2025
@nik-rev @rmburg
fix: surprising behaviour when changing line above a comment (helix-e…
0cadc7b 
…ditor#12575)

Co-authored-by: Nikita Revenco <154856872+NikitaRevenco@users.noreply.github.com>
nik-rev added a commit to nik-rev/helix that referenced this pull request Jan 24, 2025
@nik-rev
fix: surprising behaviour when changing line above a comment (helix-e…
1b1edfd 
…ditor#12575)

Co-authored-by: Nikita Revenco <154856872+NikitaRevenco@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TornaxO7 TornaxO7 TornaxO7 left review comments

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-command Area: Commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change_selection incorrectly adds comment tokens when dealing with fully selected lines
3 participants
@nik-rev @the-mikedavis @TornaxO7