Improve dark_plus theme: Change special, ui.text.directory and ui.virtual.wrap
#12530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dark_plus theme: Change 'special', ui.text.directory and ui.virtual.wrapdark_plus theme: Change special, ui.text.directory and ui.virtual.wrap
the-mikedavis
approved these changes
Jan 14, 2025
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
…`ui.virtual.wrap` (helix-editor#12530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some important changes that I hope can get merged before the upcoming patch release :)
I based the choice on the official VS Code theme using the closest available color in the
dark_plustheme:I took into account that
specialis also used as syntax and checked the change worked there too.ui.text.directoryslightly to a more VS Codish blue vibe:OLD
NEW
ui.virtual.wrapthe same color as white-space, before it was white and horrible, leaping out when it is meant to be in the background.OLD
NEW