Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(solidity): update to newest grammar and fix queries #12457

Merged
merged 8 commits into from
Jan 16, 2025
Merged

chore(solidity): update to newest grammar and fix queries #12457

merged 8 commits into from
Jan 16, 2025

Conversation

beeb
Copy link
Contributor

@beeb beeb commented Jan 9, 2025 •
edited
Loading

This PR updates the solidity grammar to the latest version and fixes the queries to work with it.

At the same time, a few improvements were made:

  • user-defined types are colored like types also in their definition statement
  • identifiers that are SCREAMING_SNAKE_CASE are colored as constants
  • add missing keywords: type, transient, immutable
  • fixed modifier invocation query
  • fix locals query for variable declaration and add constructor scope
  • change some textobject queries to use entry instead of parameter where it makes sense

@beeb beeb marked this pull request as draft January 9, 2025 07:50
@beeb
Copy link
Contributor Author

beeb commented Jan 9, 2025 •
edited
Loading

Blocked by JoranHonig/tree-sitter-solidity#68

Many queries had to be fixed because of breaking changes to the grammar.

@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Jan 9, 2025
@beeb beeb changed the title chore(solidity): add keyword highlight chore(solidity): update to newest grammar and fix queries Jan 15, 2025
@beeb beeb marked this pull request as ready for review January 15, 2025 16:44
@beeb beeb mentioned this pull request Jan 15, 2025
Closed
@the-mikedavis the-mikedavis merged commit 29dda14 into helix-editor:master Jan 16, 2025
6 checks passed
rmburg pushed a commit to rmburg/helix that referenced this pull request Jan 20, 2025
@beeb @rmburg
chore(solidity): update to newest grammar and fix queries (helix-edit…
eeffde1 
…or#12457)
nik-rev pushed a commit to nik-rev/helix that referenced this pull request Jan 24, 2025
@beeb @nik-rev
chore(solidity): update to newest grammar and fix queries (helix-edit…
4a57b93 
…or#12457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beeb @the-mikedavis