fix (hx --health): Don't print headers in white #12355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, I've improved this to print the table headers in bold so they still have some kind of visual highlighting. |
If the terminal has a white background, this makes them invisible. Make them bold instead. Fixes helix-editor#5516
jeanas
commented
Dec 29, 2024
|
|
||
| // We can't directly use println!() because of | ||
| // https://github.com/crossterm-rs/crossterm/issues/589 | ||
| let _ = crossterm::execute!(std::io::stdout(), Print(data)); |
There was a problem hiding this comment.
Note to reviewers: this workaround was not actually necessary (as can be verified by changing this line to write!(std::io::stdout(), "{}", data);). The linked crossterm issue is about the Display implementation of crossterm types, which is not relevant because the format! call works on strings and styling is added later. This was probably an artifact of refactoring.
|
Before this PR:
In a light terminal:
After PR:
|
TornaxO7
approved these changes
Dec 29, 2024
medzernik
added a commit
to medzernik/helix
that referenced
this pull request
Dec 29, 2024
fix (hx --health): Don't print headers in white (helix-editor#12355)
medzernik
added a commit
to medzernik/helix
that referenced
this pull request
Dec 29, 2024
medzernik
added a commit
to medzernik/helix
that referenced
this pull request
Dec 29, 2024
Revert "fix (hx --health): Don't print headers in white (helix-editor#12355)"
medzernik
pushed a commit
to medzernik/helix
that referenced
this pull request
Dec 29, 2024
julianbieber
pushed a commit
to julianbieber/helix
that referenced
this pull request
Dec 29, 2024
CedricMeu
pushed a commit
to CedricMeu/helix
that referenced
this pull request
Jan 2, 2025
akhenakh
pushed a commit
to akhenakh/helix
that referenced
this pull request
Jan 4, 2025
GladkihEgor
pushed a commit
to GladkihEgor/helix
that referenced
this pull request
Jan 4, 2025
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Jan 6, 2025
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
julianbieber
pushed a commit
to julianbieber/helix
that referenced
this pull request
Jan 15, 2025
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
julianbieber
pushed a commit
to julianbieber/helix
that referenced
this pull request
Jan 20, 2025
julianbieber
pushed a commit
to julianbieber/helix
that referenced
this pull request
Jan 28, 2025
julianbieber
pushed a commit
to julianbieber/helix
that referenced
this pull request
Feb 19, 2025
julianbieber
pushed a commit
to julianbieber/helix
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the terminal has a white background, this makes them invisible.
fixes #5516