-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
language: add comment token for java files #12266
Merged
the-mikedavis
merged 1 commit into
helix-editor:master
from
TornaxO7:fix-java-default-comment-token
Dec 16, 2024
Merged
language: add comment token for java files #12266
the-mikedavis
merged 1 commit into
helix-editor:master
from
TornaxO7:fix-java-default-comment-token
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Dec 16, 2024
I configured comment-token and the block comment stopped working, acting like the line comment. keys space+C |
the-mikedavis
added a commit
that referenced
this pull request
Dec 16, 2024
We also need a block comment token config. I've added one for Java in bae6a58 |
CedricMeu
pushed a commit
to CedricMeu/helix
that referenced
this pull request
Jan 2, 2025
CedricMeu
pushed a commit
to CedricMeu/helix
that referenced
this pull request
Jan 2, 2025
GladkihEgor
pushed a commit
to GladkihEgor/helix
that referenced
this pull request
Jan 4, 2025
GladkihEgor
pushed a commit
to GladkihEgor/helix
that referenced
this pull request
Jan 4, 2025
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was introduced from #12080 since the default comment got changed.
Fixes #12265