Fix panic in kill_to_end_of_line when handling multibyte characters
#12237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helix-term/src/ui/prompt.rs
Outdated
| @@ -234,8 +234,8 @@ impl Prompt { | |||
| } | |||
| Movement::StartOfLine => 0, | |||
| Movement::EndOfLine => { | |||
There was a problem hiding this comment.
I think this branch can just return self.line.len() instead
There was a problem hiding this comment.
Thank you. That worked and I've fixed it.
7431de5 to
fe08767
Compare
the-mikedavis
approved these changes
Dec 13, 2024
CedricMeu
pushed a commit
to CedricMeu/helix
that referenced
this pull request
Jan 2, 2025
GladkihEgor
pushed a commit
to GladkihEgor/helix
that referenced
this pull request
Jan 4, 2025
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed a panic that occurred when pressing Ctrl-a Ctrl-k in prompts while a multibyte string was inserted.
Before:
b.mp4
After:
a.mp4