Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amber-lang #12021

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Add support for Amber-lang #12021

merged 6 commits into from
Nov 21, 2024

Conversation

lens0021
Copy link
Contributor

@lens0021 lens0021 commented Nov 7, 2024

@lens0021
Copy link
Contributor Author

lens0021 commented Nov 7, 2024

@Ph0enixKM Hi, Could I use your code in this PR? If you are okay, I will mark this PR as ready for review.

@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Nov 7, 2024
@Ph0enixKM
Copy link
Contributor

Ph0enixKM commented Nov 19, 2024

@lens0021 looking good... I'm just thinking how would the highlights.scm be synchronized with the current Amber version later on in the future? Would you be updating it here?

@lens0021
Copy link
Contributor Author

@lens0021 looking good... I'm just thinking how would the highlights.scm be synchronized with the current Amber version later on in the future? Would you be updating it here?

I think it is common to manually updating the SHA in this repo. But I am not sure.

@lens0021 lens0021 marked this pull request as ready for review November 19, 2024 13:37
@lens0021
Copy link
Contributor Author

(* so it is possible to sync the files using the same PR in manual way)

@Ph0enixKM
Copy link
Contributor

Ph0enixKM commented Nov 20, 2024

Okay then, there is no problem! @lens0021 could you add the Helix editor to the list of supported editors on our website? The section mentioning it is located here: https://docs.amber-lang.com/getting_started/usage#syntax-highlighting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think brackets.scm is specific to Zed. We don't currently have equivalent queries so this file can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@the-mikedavis
Copy link
Member

Updating highlights.scm is usually done manually when updating the revision in languages.toml. (For example the tree-sitter parser might expose new nodes to be highlighted and those would be added to the highlights when updating the revision.)

@lens0021
Copy link
Contributor Author

rebased

lens0021 and others added 2 commits November 21, 2024 10:38
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
@the-mikedavis the-mikedavis merged commit f305c72 into helix-editor:master Nov 21, 2024
GladkihEgor pushed a commit to GladkihEgor/helix that referenced this pull request Jan 4, 2025
Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
diucicd pushed a commit to diucicd/helix that referenced this pull request Jan 8, 2025
Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
rmburg pushed a commit to rmburg/helix that referenced this pull request Jan 20, 2025
Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add amber-lang support
3 participants