-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade solana-sdk to 2.x #74
Conversation
dougEfresh
commented
Oct 10, 2024
- Upgrade solana* to 2.0.10
- Fix URL for mainnet api
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "helius" | |||
version = "0.2.1" | |||
version = "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reflect that this uses 2.x of solana-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with the huge version bump to 2.0.0 — I understand the rationale to be on par with other Solana SDK versions. Still, it doesn't make sense within this context as the semver is specific to the Helius SDK and this is technically just a dependency update. Can you please bump it to 0.2.2?
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "helius" | |||
version = "0.2.1" | |||
version = "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with the huge version bump to 2.0.0 — I understand the rationale to be on par with other Solana SDK versions. Still, it doesn't make sense within this context as the semver is specific to the Helius SDK and this is technically just a dependency update. Can you please bump it to 0.2.2?
Can be considered closed by #80. Thank you for your contribution! |