Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade solana-sdk to 2.x #74

Closed
wants to merge 6 commits into from
Closed

Conversation

dougEfresh
Copy link
Contributor

  • Upgrade solana* to 2.0.10
  • Fix URL for mainnet api

@@ -1,6 +1,6 @@
[package]
name = "helius"
version = "0.2.1"
version = "2.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reflect that this uses 2.x of solana-sdk

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with the huge version bump to 2.0.0 — I understand the rationale to be on par with other Solana SDK versions. Still, it doesn't make sense within this context as the semver is specific to the Helius SDK and this is technically just a dependency update. Can you please bump it to 0.2.2?

@@ -1,6 +1,6 @@
[package]
name = "helius"
version = "0.2.1"
version = "2.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with the huge version bump to 2.0.0 — I understand the rationale to be on par with other Solana SDK versions. Still, it doesn't make sense within this context as the semver is specific to the Helius SDK and this is technically just a dependency update. Can you please bump it to 0.2.2?

@0xIchigo 0xIchigo mentioned this pull request Oct 22, 2024
@0xIchigo
Copy link
Collaborator

Can be considered closed by #80. Thank you for your contribution!

@0xIchigo 0xIchigo closed this Oct 23, 2024
@dougEfresh dougEfresh deleted the 2.x branch November 5, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants