#757 Fixed new weird sorting UI bug

helgoboss · Jun 2, 2023 · e1cc03b · e1cc03b
1 parent 0cbfcfe
commit e1cc03b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 17 deletions.
diff --git a/dialogs/src/base.rs b/dialogs/src/base.rs
@@ -689,7 +689,6 @@ pub enum Style {
     WS_CHILD,
     CBS_DROPDOWNLIST,
     CBS_HASSTRINGS,
-    CBS_SORT,
     ES_MULTILINE,
     ES_READONLY,
     ES_WANTRETURN,

diff --git a/dialogs/src/mapping_panel.rs b/dialogs/src/mapping_panel.rs
@@ -466,8 +466,7 @@ pub fn create(context: ScopedContext, ids: &mut IdGenerator) -> Dialog {
         dropdown(
             ids.named_id("IDC_MODE_FEEDBACK_TYPE_COMBO_BOX"),
             context.rect(231, 306, 163, 30),
-        ) + CBS_SORT
-            + WS_TABSTOP,
+        ) + WS_TABSTOP,
         edittext(
             ids.named_id("ID_MODE_EEL_FEEDBACK_TRANSFORMATION_EDIT_CONTROL"),
             context.rect(231, 323, 179, 14),

diff --git a/resources/test-projects/issue-757-lua-feedback-script.RPP b/resources/test-projects/issue-757-lua-feedback-script.RPP
@@ -1,4 +1,4 @@
-<REAPER_PROJECT 0.1 "6.79+dev0502/macOS-arm64" 1685732428
+<REAPER_PROJECT 0.1 "6.79+dev0502/macOS-arm64" 1685733855
   <NOTES 0 2
   >
   RIPPLE 0
@@ -69,7 +69,7 @@
   MASTERTRACKVIEW 0 0.6667 0.5 0.5 0 0 0 0 0 0 0 0 0 0
   MASTERHWOUT 0 0 1 0 0 0 0 -1
   MASTER_NCH 2 2
-  MASTER_VOLUME 0.13990929218607 0 -1 -1 1
+  MASTER_VOLUME 0.78304335735222 0 -1 -1 1
   MASTER_PANMODE 3
   MASTER_FX 1
   MASTER_SEL 0
@@ -120,22 +120,22 @@
       DOCKED 0
       BYPASS 0 0 0
       <VST "VSTi: ReaLearn (Helgoboss)" realearn.vst.dylib 0 "" 1751282284<5653546862726C7265616C6561726E00> ""
-        bHJiaO5e7f4CAAAAAQAAAAAAAAACAAAAAAAAAAAAAABhBAAAAQAAAAAAEAA=
+        bHJiaO5e7f4CAAAAAQAAAAAAAAACAAAAAAAAAAAAAABmBAAAAQAAAAAAEAA=
         eyJ2ZXJzaW9uIjoiMi4xNS4wIiwiaWQiOiJJaHRfbjFRQiIsInN0YXlBY3RpdmVXaGVuUHJvamVjdEluQmFja2dyb3VuZCI6Ik9ubHlJZkJhY2tncm91bmRQcm9qZWN0
         SXNSdW5uaW5nIiwic2VuZEZlZWRiYWNrT25seUlmQXJtZWQiOnRydWUsImZlZWRiYWNrRGV2aWNlSWQiOiJmeC1vdXRwdXQiLCJkZWZhdWx0R3JvdXAiOnt9LCJkZWZh
-        dWx0Q29udHJvbGxlckdyb3VwIjp7fSwibWFwcGluZ3MiOlt7ImlkIjoiTWc5X3Raejh0bTcyRnRVaWVGSlhGIiwibmFtZSI6IjFkIiwic291cmNlIjp7ImNhdGVnb3J5
-        IjoicmVhcGVyIiwidHlwZSI6MTIsImlzUmVnaXN0ZXJlZCI6ZmFsc2UsImlzMTRCaXQiOmZhbHNlLCJvc2NBcmdJbmRleCI6MCwicmVhcGVyU291cmNlVHlwZSI6InNw
-        ZWVjaCJ9LCJtb2RlIjp7Im1heFN0ZXBTaXplIjowLjA1LCJtaW5TdGVwRmFjdG9yIjoxLCJtYXhTdGVwRmFjdG9yIjo1LCJlZWxGZWVkYmFja1RyYW5zZm9ybWF0aW9u
-        IjoiaWYgY29udGV4dC5tb2RlID09IDEgdGhlblxuICAgcmV0dXJuIHtcbiAgICAgICAgdXNlZF9wcm9wcyA9IHsgXCJ0YXJnZXQudGV4dF92YWx1ZVwiIH1cbiAgIH1c
-        bmVsc2VcbiAgICBjb3VudGVyID0gY291bnRlciBvciAwXG4gICAgY291bnRlciA9IGNvdW50ZXIgKyAxXG5cbiAgICByZXR1cm4ge1xuICAgICAgICAgICAgICAgIGZl
-        ZWRiYWNrX2V2ZW50ID0ge1xuICAgICAgICAgICAgICAgICAgICB2YWx1ZSA9IFwiXCIgLi4gY291bnRlclxuICAgICAgICAgICAgICAgIH0sXG4gICAgICAgICAgICB9
-        IFxuZW5kIiwiZmVlZGJhY2tUeXBlIjoyfSwidGFyZ2V0Ijp7InR5cGUiOjIsInRyYWNrR1VJRCI6Im1hc3RlciIsImZ4QW5jaG9yIjoiaWQiLCJ1c2VTZWxlY3Rpb25H
-        YW5naW5nIjpmYWxzZSwidXNlVHJhY2tHcm91cGluZyI6ZmFsc2UsInNlZWtCZWhhdmlvciI6IkltbWVkaWF0ZSIsInVzZVByb2plY3QiOnRydWUsIm1vdmVWaWV3Ijp0
-        cnVlLCJzZWVrUGxheSI6dHJ1ZSwib3NjQXJnSW5kZXgiOjAsIm1vdXNlQWN0aW9uIjp7ImtpbmQiOiJNb3ZlVG8iLCJheGlzIjoiWSJ9LCJ0YWtlTWFwcGluZ1NuYXBz
-        aG90Ijp7ImtpbmQiOiJMYXN0TG9hZGVkIn19fV0sImluc3RhbmNlRngiOnsiYWRkcmVzcyI6IkZvY3VzZWQifX0=
+        dWx0Q29udHJvbGxlckdyb3VwIjp7fSwibWFwcGluZ3MiOlt7ImlkIjoiTWc5X3Raejh0bTcyRnRVaWVGSlhGIiwibmFtZSI6IkNvdW50ZXIiLCJzb3VyY2UiOnsiY2F0
+        ZWdvcnkiOiJyZWFwZXIiLCJ0eXBlIjoxMiwiaXNSZWdpc3RlcmVkIjpmYWxzZSwiaXMxNEJpdCI6ZmFsc2UsIm9zY0FyZ0luZGV4IjowLCJyZWFwZXJTb3VyY2VUeXBl
+        Ijoic3BlZWNoIn0sIm1vZGUiOnsibWF4U3RlcFNpemUiOjAuMDUsIm1pblN0ZXBGYWN0b3IiOjEsIm1heFN0ZXBGYWN0b3IiOjUsImVlbEZlZWRiYWNrVHJhbnNmb3Jt
+        YXRpb24iOiJpZiBjb250ZXh0Lm1vZGUgPT0gMSB0aGVuXG4gICByZXR1cm4ge1xuICAgICAgICB1c2VkX3Byb3BzID0geyBcInRhcmdldC50ZXh0X3ZhbHVlXCIgfVxu
+        ICAgfVxuZWxzZVxuICAgIGNvdW50ZXIgPSBjb3VudGVyIG9yIDBcbiAgICBjb3VudGVyID0gY291bnRlciArIDFcblxuICAgIHJldHVybiB7XG4gICAgICAgICAgICAg
+        ICAgZmVlZGJhY2tfZXZlbnQgPSB7XG4gICAgICAgICAgICAgICAgICAgIHZhbHVlID0gXCJcIiAuLiBjb3VudGVyXG4gICAgICAgICAgICAgICAgfSxcbiAgICAgICAg
+        ICAgIH0gXG5lbmQiLCJmZWVkYmFja1R5cGUiOjJ9LCJ0YXJnZXQiOnsidHlwZSI6MiwidHJhY2tHVUlEIjoibWFzdGVyIiwiZnhBbmNob3IiOiJpZCIsInVzZVNlbGVj
+        dGlvbkdhbmdpbmciOmZhbHNlLCJ1c2VUcmFja0dyb3VwaW5nIjpmYWxzZSwic2Vla0JlaGF2aW9yIjoiSW1tZWRpYXRlIiwidXNlUHJvamVjdCI6dHJ1ZSwibW92ZVZp
+        ZXciOnRydWUsInNlZWtQbGF5Ijp0cnVlLCJvc2NBcmdJbmRleCI6MCwibW91c2VBY3Rpb24iOnsia2luZCI6Ik1vdmVUbyIsImF4aXMiOiJZIn0sInRha2VNYXBwaW5n
+        U25hcHNob3QiOnsia2luZCI6Ikxhc3RMb2FkZWQifX19XSwiaW5zdGFuY2VGeCI6eyJhZGRyZXNzIjoiRm9jdXNlZCJ9fQ==
         AFByb2dyYW0gMQAQAAAA
       >
-      FLOAT 994 167 752 675
+      FLOATPOS 994 167 752 675
       FXID {32CE7E47-4532-4549-BDFC-C7521E95FA48}
       WAK 0 0
     >