-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(build): release armv7 binary #419
(build): release armv7 binary #419
Conversation
Hmm, I disabled x86 builds on purpose because we have some 64bit only code I believe. I can check and if it's possible to fix this code to support 32bit systems then we could make armv7 builds. You say that it works for you or RPi? |
Version v0.29.1 works on rpi 4. - env:
- CGO_ENABLED=0
goos:
- linux
goarch:
- arm
goarm:
- 7 |
Could you also add goreleaser config for building the armv7 docker image? I believe it uses the following Docker platform: |
It seems with Go int64 works on 32bit systems, by using 2x32bit registers and simulating 64bit arithmethic which is slower (but in our use case it's just a few consts so no problem, although I need to check for one bug that could appear before merging this). |
545e30b
to
a56d45e
Compare
Edit: Also added it to "image_templates". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's see if it works :)
Thanks for your contribution and do let me know how v0.29.2 works out for you :) |
Nothing. |
Just tested it and it works! |
Just a follow up: today I've added and released frontend docker image that supports arm/v7 in case you need it |
The armv7 binary will be build when using goreleaser with
release.yml
.The produced output was previously tested on a rpi.