Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(build): release armv7 binary #419

Merged

Conversation

allendema
Copy link
Contributor

The armv7 binary will be build when using goreleaser with release.yml.
The produced output was previously tested on a rpi.

@aleksasiriski
Copy link
Member

aleksasiriski commented Oct 14, 2024

Hmm, I disabled x86 builds on purpose because we have some 64bit only code I believe. I can check and if it's possible to fix this code to support 32bit systems then we could make armv7 builds.

You say that it works for you or RPi?

@allendema
Copy link
Contributor Author

Version v0.29.1 works on rpi 4.
Used a goreleaser template with these values modified - and there were results returned:

  - env:
      - CGO_ENABLED=0
    goos:
      - linux
    goarch:
      - arm
    goarm:
      - 7

@aleksasiriski
Copy link
Member

Could you also add goreleaser config for building the armv7 docker image? I believe it uses the following Docker platform: linux/arm/v7

@aleksasiriski
Copy link
Member

It seems with Go int64 works on 32bit systems, by using 2x32bit registers and simulating 64bit arithmethic which is slower (but in our use case it's just a few consts so no problem, although I need to check for one bug that could appear before merging this).

@aleksasiriski aleksasiriski self-assigned this Oct 14, 2024
@allendema allendema force-pushed the ad/build/release-armv7-binary branch from 545e30b to a56d45e Compare October 14, 2024 14:51
@allendema
Copy link
Contributor Author

allendema commented Oct 14, 2024

config for building the armv7 docker image?

Yeah, pushed the changes just now.

Edit: Also added it to "image_templates".

Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see if it works :)

@aleksasiriski
Copy link
Member

Thanks for your contribution and do let me know how v0.29.2 works out for you :)

@allendema
Copy link
Contributor Author

Nothing.
Will give it a spin soon. :)

@allendema
Copy link
Contributor Author

Just tested it and it works!

@aleksasiriski
Copy link
Member

Just a follow up: today I've added and released frontend docker image that supports arm/v7 in case you need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants