Feat: Added closeOnChangedValue functionality. #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdokimakis thanks for the PR, is it possible to call it Also for #527 I was thinking of providing ref based control to make it much more simple for advanced conditions, but this might be nice too... reference: |
|
@harshzalavadiya regarding the closeMenuOnSelect vs closeOnValueChange: The difference is that the feature I implemented closes the menu on both selecting and deselecting of a value. So renaming it to closeMenuOnSelect might be confusing, but I'm not 100% committed to that point of view, so if it sits better with you, I'll do it. |
|
@bdokimakis that's valid point, I guess let's keep it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good-to-have feature and will maybe be helpful for #527 as well.