Blackjack bug fixes #2550
Merged
Blackjack bug fixes #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Fixed bet increment/decrement logic. Will allow player to max out bet to available money. When decrementing the bet, will remove the portion not part of the standard decrement, if not a multiple of that decrement. -Fixed the gameMenu logic regarding when to allow splits and double downs, as related to player money and the current wager. Existing logic would not allow a double down or split under certain conditions (e.g., when trying to double down after splitting, could not double down if player money was not at least 4x greater than the current bet, logic should actual check if player is capable of adding another currentBet to wager). -Fixed dealer winning on blackjack even if player has blackjack. Now it's a push if player also has blackjack.
|
This has needed some love for a while now. Great work! |
|
Awesome work LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixed bet increment/decrement logic. Will allow player to max out bet to available money. When decrementing the bet, will remove the portion not part of the standard decrement, if not a multiple of that decrement.
-Fixed the gameMenu logic regarding when to allow splits and double downs, as related to player money and the current wager. Existing logic would not allow a double down or split under certain conditions (e.g., when trying to double down after splitting, could not double down if player money was not at least 4x greater than the current bet, logic should actual check if player is capable of adding another currentBet to wager).
-Fixed dealer winning on blackjack even if player has blackjack. Now it's a push if player also has blackjack.