Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway page #918

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Gateway page #918

merged 5 commits into from
Oct 31, 2024

Conversation

Harvey1214
Copy link
Member

No description provided.

@Harvey1214 Harvey1214 requested a review from hakenr October 31, 2024 10:03
@Harvey1214 Harvey1214 self-assigned this Oct 31, 2024
hakenr
hakenr requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole gateway feature should not be scoped "to GitHub", but "to Premium content" in general. The target URL does not have to be GitHub.

@Harvey1214 Harvey1214 requested a review from hakenr October 31, 2024 15:06
hakenr
hakenr approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix the comments and merge the PR.

@hakenr hakenr merged commit aa4c10f into master Oct 31, 2024
1 check passed
@hakenr hakenr deleted the feature/GatewayPage branch October 31, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakenr hakenr hakenr approved these changes

Assignees

@Harvey1214 Harvey1214

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Harvey1214 @hakenr