Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Canonical URLs metadata #914 #915

Merged
merged 6 commits into from
Nov 2, 2024
Merged

[Doc] Canonical URLs metadata #914 #915

merged 6 commits into from
Nov 2, 2024

Conversation

Harvey1214
Copy link
Member

No description provided.

@Harvey1214 Harvey1214 requested a review from hakenr October 30, 2024 12:04
@Harvey1214 Harvey1214 self-assigned this Oct 30, 2024
@Harvey1214 Harvey1214 linked an issue Oct 30, 2024 that may be closed by this pull request
@hakenr
Copy link
Member

hakenr commented Oct 30, 2024

We need this to cover most pages (if not all). See the list of duplicates identified by Google Search Console.
Consider using a root cascading value to manage the registrations. I think the first one should always take precedence (no need for MainComponent). We can add a special <PageCanonicalUrl /> component to act as the initial registrant in cases where the order of components on the page doesn't satisfy the rule.

Duplicate URLs without canonical.txt

Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my previous comment

@Harvey1214 Harvey1214 requested a review from hakenr October 31, 2024 14:48
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consolidated, merged master, lgtm

@hakenr hakenr merged commit bda7ad2 into master Nov 2, 2024
1 check passed
@hakenr hakenr deleted the feature/CanonicalURLs branch November 2, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Canonical URLs metadata
2 participants