Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HxSearchBox] Search icon missaligned when used with label #487 #489

Merged
merged 6 commits into from
Mar 28, 2023
Merged

[HxSearchBox] Search icon missaligned when used with label #487 #489

merged 6 commits into from
Mar 28, 2023

Conversation

Harvey1214
Copy link
Member

No description provided.

@Harvey1214 Harvey1214 requested a review from crdo March 3, 2023 17:39
@Harvey1214 Harvey1214 self-assigned this Mar 3, 2023
hakenr
hakenr requested changes Mar 4, 2023
View reviewed changes
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor adjustments needed from coding point of view.
@crdo, can you please review the HTML/CSS?

@crdo
Copy link
Member

crdo commented Mar 6, 2023

I don't like the way the HxSearch is implemented from the structure POV.
It is very similar as the HxAutosuggest that supports clear/search icon with input groups but here, we turn icons off if inputs are used. I think these two should be aligned.
image

@Harvey1214 Harvey1214 requested a review from hakenr March 17, 2023 14:32
Harvey1214
Harvey1214 commented Mar 17, 2023
View reviewed changes
Havit.Blazor.Components.Web.Bootstrap/Forms/SearchBox/HxSearchBox.razor.css Outdated
@@ -17,11 +17,6 @@
right: .75rem;
}

::deep .hx-search-box-input-with-search-icon {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crdo this class is necessary when InputGroupStartText or InputGroupStartTemplate is set because otherwise the corners aren't rounded.

@Harvey1214
Copy link
Member Author

Harvey1214 commented Mar 17, 2023 •
edited
Loading

I don't like the way the HxSearch is implemented from the structure POV. It is very similar as the HxAutosuggest that supports clear/search icon with input groups but here, we turn icons off if inputs are used. I think these two should be aligned. image

That's a good point, I'd suggest creating a different issue for this matter.

hakenr
hakenr approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hakenr hakenr merged commit 0f1a965 into master Mar 28, 2023
@hakenr hakenr deleted the feature/HxSearchBox_MissalignedSearchIconWhenLabelIsShown branch March 28, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakenr hakenr hakenr approved these changes

@crdo crdo Awaiting requested review from crdo

Assignees

@Harvey1214 Harvey1214

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harvey1214 @crdo @hakenr