Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HxListLayout and ChipList implementation and demo cleanup #1012

Merged
merged 2 commits into from
Feb 11, 2025
Merged

HxListLayout and ChipList implementation and demo cleanup #1012

merged 2 commits into from
Feb 11, 2025

Conversation

crdo
Copy link
Member

@crdo crdo commented Feb 11, 2025

HxListLayout

  • Removed utility classes in favour of css isolation
  • Added space between header and chips
  • Switched filter/commands template order (filter button is always last)

ChipList

  • Improved remove button visual
  • Added missing CSS vars to docs
  • Switched spacing to gap + new CSS var

@crdo crdo requested a review from hakenr February 11, 2025 08:50
hakenr
hakenr approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hakenr hakenr merged commit 7a4d3d2 into master Feb 11, 2025
1 check passed
@hakenr hakenr deleted the feature/HxListLayoutAndChipListTuning branch February 11, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakenr hakenr hakenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crdo @hakenr