Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django-stubs to the list of projects #124

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

sobolevn
Copy link
Contributor

Let's try it!

Copy link
Owner

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think you'll need some sort of install command to install the plugin you want to use while checking django-stubs (possible just install_cmd="{install} .",)

@hauntsaninja hauntsaninja merged commit 541bb89 into hauntsaninja:master Jul 23, 2024
1 check passed
@sobolevn
Copy link
Contributor Author

sobolevn commented Jul 23, 2024

@hauntsaninja how can I test that the whole intergration worked? new mypy PR or something?

@sobolevn
Copy link
Contributor Author

Thanks for the quick review and merge! ❤️

@hauntsaninja
Copy link
Owner

Yes, that'll work. I also just ran it locally before merging using mypy_primer -k django-stub --debug --old v1.10.0

@AlexWaygood
Copy link
Contributor

Some strange resolution failure here when trying to install django-stubs: https://github.com/python/typeshed/actions/runs/10112015097/job/27965167268?pr=12433.

Hopefully just a fluke of some kind, I'll try rerunning

@sobolevn
Copy link
Contributor Author

@flaeppe looks like our release is partially broken :(

@flaeppe
Copy link

flaeppe commented Jul 26, 2024

I think we just need to make a release. We only prepared for one.

@sobolevn
Copy link
Contributor Author

sobolevn commented Jul 26, 2024

oh, I see then why it fails: we bumped the dependency in git and not released ext@5.0.3

@flaeppe
Copy link

flaeppe commented Jul 26, 2024

But something seems quite off if we're installing . on master and run in to troubles. When installing in our CI, with pip, we set the env variable SETUPTOOLS_ENABLE_FEATURES=legacy-editable not sure if that affects anything

@andersk
Copy link
Contributor

andersk commented Jul 26, 2024

We need to install both . and ./ext from Git, not just ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants