Reviews_BE #66
Open
Reviews_BE #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com>
Open
dproc96
reviewed
Jun 22, 2021
Comment on lines
+16
to
+20
| if (userId === req.body.userId) { | ||
| return res.status(401).json({ | ||
| error: "User is not authorized for reviewing their own profile" | ||
| }); | ||
| } |
server/models/Review.js
Outdated
| reviewerUserId: { | ||
| type: ObjectId, | ||
| ref: "user", | ||
| unique: true, |
There was a problem hiding this comment.
This means a user can only write one review ever, if you're trying to prevent having multiple reviews of and by the same user you could either do that in the controller or have a separate unique value that combines the two ids
| const { Schema } = mongoose; | ||
| const { ObjectId } = Schema; | ||
|
|
||
| const reviewSchema = new mongoose.Schema({ |
There was a problem hiding this comment.
Can we add a field for a written review and not require it?
server/controllers/review.js
Outdated
Comment on lines
49
to
52
| Review.aggregate( | ||
| [ | ||
| { $group: { _id: "$userId", avgRating: { $avg: "$rating" } } } | ||
| ] |
There was a problem hiding this comment.
This is getting the average rating of all users, this is not the best approach. I don't think having a specific route for this is ideal, would be better to have a way to populate this value in the profile when fetching the profile
Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com>
Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gurkiran_singh gurkiransinghk@gmail.com
What this PR does (required):
Screenshots / Videos (required):
N/A
Any information needed to test this feature (required):
Any issues with the current functionality (optional):
No