Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove google-home-notify #61

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Remove google-home-notify #61

merged 2 commits into from
Oct 29, 2018

Conversation

heytcass
Copy link
Contributor

Proposed Changes

The google-home-notify component is currently broken. There is an issue filed upstream, and even a PR to fix the issue proposed, but the developer seems to be unresponsive. See here: nabbl/node-red-contrib-google-home-notify#25 Propose removing as a pre-installed module until fixed.

The google-home-notify component is currently broken. There is an issue filed upstream, and even a PR to fix the issue proposed, but the developer seems to be unresponsive. See here: nabbl/node-red-contrib-google-home-notify#25 Propose removing as a pre-installed module until fixed.
@addons-assistant
Copy link

💖 Thanks for opening this pull request! 💖 If your PR gets accepted and merged in, we will invite you to the project 🎉

@frenck
Copy link
Member

frenck commented Oct 25, 2018

The main issue seems to be the underlying google-tts-api package.
Instead of removing this, we could also provide a custom resolution to npm for google-tts-api to install version 0.0.3. That would fix it, right?

@heytcass
Copy link
Contributor Author

In theory, yes. Although some people in the linked thread seem to say it still goes kaput after a bit even with that solution. But worth a shot.

@ghost ghost assigned frenck Oct 29, 2018
@frenck
Copy link
Member

frenck commented Oct 29, 2018

@heytcass Let's try that path first, we can always remove it in the future.

I've added a resolution.

@frenck frenck merged commit 1f788c6 into hassio-addons:master Oct 29, 2018
@addons-assistant
Copy link

Congrats on merging your first pull request! 🎉🎉🎉

@heytcass heytcass deleted the patch-1 branch October 29, 2018 14:05
@addons-assistant
Copy link

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@addons-assistant addons-assistant bot locked as resolved and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants