Add gcc build dependency #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed to build the psutil requirement
frenck
requested changes
Sep 18, 2022
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
approved these changes
Sep 19, 2022
|
Ugh, why don't they have the prebuilt we need anymore. Looks like it also wants |
Our base images also pick up Home Assistant wheels (https://wheels.home-assistant.io), that is the reason it now needs a bit more (as HA hasn't bumped yet). |
|
Oh I see, I expected the build to check home assistant wheels in addition to pypi. So if a PR is merged in HA core to bump psutil (used for systemmonitor), the wheels for that will also be build? |
Yes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add gcc build dependency, which seems needed to build the psutil requirement
Related Issues
Needed for #279