Replace highlight.js with static highlighting using Pandoc #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cde36a to
09c539b
Compare
Co-authored-by: tauomicronmu <tauomicronmurs@gmail.com>
09c539b to
3eab4ff
Compare
david-christiansen
suggested changes
Jun 12, 2023
message-index/site.hs
Outdated
| other -> other, | ||
| field "before" (maybe (pure "<not present>") (fmap itemBody . load . itemIdentifier) . view _2 . itemBody), | ||
| field "after" (maybe (pure "<not present>") (fmap itemBody . load . itemIdentifier) . view _3 . itemBody) | ||
| -- TODO: pick the right language |
There was a problem hiding this comment.
Is this a stale TODO?
There was a problem hiding this comment.
I'll have a look at it now!
| case takeExtension name of | ||
| ".hs" -> "haskell" | ||
| _ -> "" | ||
| pure $ T.unpack $ highlight language $ T.pack $ exampleText |
Check notice
Code scanning / HLint
Redundant $
Co-authored-by: Daan Rijks <daanrijks@pm.me>
56037cd to
d2cf854
Compare
|
Is this still a draft? What do you see as the remaining tasks for un-drafting it? |
|
@isomorpheme - completely forgot about this -> do you remember what we had left to do (if anything)? |
|
@TauOmicronMu Hmm, I don't remember anything besides what's already mentioned in this PR (mainly picking the right language to highlight with). And this needs a rebase to fix merge conflicts of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥳 🎉