Fix #227 #229
Merged
Fix #227 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Aug 22, 2018
.travis.yml
Outdated
| - compiler: "ghc-8.6.1" | ||
| env: GHCHEAD=true | ||
| addons: {apt: {packages: [ghc-ppa-tools,cabal-install-head,ghc-8.6.1], sources: [hvr-ghc]}} | ||
| # Fails due to GHC #15436 |
There was a problem hiding this comment.
When you say "fails", is it the entire library that fails to build? Just the tests?
If it's the former, we shouldn't list GHC 8.4.3 under tested-with. If it's the latter, maybe we should uncomment this and simply enable TEST=--disable-tests.
There was a problem hiding this comment.
Just the tests.
If it's the former, we shouldn't list GHC 8.4.3 under tested-with. If it's the latter, maybe we should uncomment this and simply enable TEST=--disable-tests.
Sounds good to me.
Sadly GHC croaks due to GHC #15436.
|
@bgamari I need to start writing down all the issues w/ GHC 8.4.3 I'd like to see resolved in a GHC 8.4.4 point rls... |
Closed
|
How is this looking? |
|
@bgamari good :-) But I'll test it locally a bit more |
bgamari
added a commit
to bgamari/ghc
that referenced
this pull request
Oct 5, 2018
This introduces the fix for haskell/text#229.
bgamari
added a commit
to bgamari/ghc
that referenced
this pull request
Oct 5, 2018
This introduces the fix for haskell/text#229.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs:
caseConvertwas incorrectly (albeit subtly) associated, resulting in a much large size that overflowed the machine integertakeanddropfusion combinators failed to clamp negative counts, resulting in underflows.In addition it does a fair bit of spring cleaning, adding GHC 8.6.1 to the
Tested-Withconfiguration list, dropping a redundantbug-reportsfield, and regeneratingtravis.yml.