Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for post qualified import formatting (more cases) #372

Merged

Conversation

akrmn
Copy link
Contributor

@akrmn akrmn commented Jul 12, 2021

Based on the work started by @jhmcstanton. I added a few more test cases, and adapted the logic to support them. I originally submitted this as a PR to @jhmcstanton's branch, but I haven't got a reply, so I thought submitting a PR including their commit might be simpler.

Adds an option to use post qualified module imports.

Related to #284
Resolves #334
Improves on #335

Let me know if any more tests or changes are needed.

@akrmn akrmn changed the title Post qualified imports more cases Add support for post qualified import formatting (more cases) Jul 12, 2021
Copy link
Member

@lukasz-golebiewski lukasz-golebiewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@lukasz-golebiewski lukasz-golebiewski merged commit 9c090d4 into haskell:main Jul 16, 2021
@cblp
Copy link
Contributor

cblp commented Sep 14, 2021

Could you please release this change?

@lukasz-golebiewski
Copy link
Member

@jaspervdj could you?

@jaspervdj
Copy link
Member

Released v0.13.0.0 🎊

@cblp
Copy link
Contributor

cblp commented Sep 16, 2021

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format imports qualified post
5 participants