Suppress ghc-pkg warnings emitted when an empty packages is being registered #9997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
567916c to
6ca030f
Compare
|
Thanks for that. Please let us know if you need help with CI failures and please set "review" label when ready to discuss the implementation (or even the design, though an issue ticket might be better for that). |
|
BTW, the current CI failure seems caused by the flaky macos jobs in github, so let me take the liberty of restarting the job. |
geekosaur
approved these changes
Sep 13, 2024
Kleidukos
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
@depressed-pho this PR looks good, you just have to solve the conflicts. :)
…istered When a package contains a library that has no modules, "./Setup register" tries to register the library with fields "haddock-interfaces:" and "haddock-html:" pointing at non-existent files or directories, and "ghc-pkg register" warns about them. To suppress the warnings prevent these fields from being generated when there are no modules.
bd6c7de to
eff7bf8
Compare
Did it. The tests have passed. |
|
@depressed-pho perfect, your PR will be merged by the bot in due time. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package contains a library that has no modules,
./Setup registertries to register the library with fieldshaddock-interfaces:andhaddock-html:pointing at non-existent files or directories, andghc-pkg registerwarns about them like this:To suppress the warnings prevent these fields from being generated when there are no modules.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR: