-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny refactor of how Cabal handles configure scripts #8648
Conversation
I've restarted doctests CI and now it passes (previously complained about checksums), so probably a random instability. |
As far as I can see, this is indeed a guaranteed safe refactoring, so tests are not mandatory. A changelog file would be welcome, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on a changelog file.
We don't need this function to have this parameter, and it is private so we don't need to worry about breakage.
8ce0d44
to
723b1f5
Compare
I sort of would think this sort of internal-only change would be the type of thing that belongs in the git history but not a change log, but I added a change log entry as requested. |
The new module is private for now.
723b1f5
to
10c3c45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you are probably right and I was overzealous. This is not even a change of API, because the module is not yet visible. Anyway, it doesn't hurt.
Please feel free to set a merge label. |
@Ericson2314 please, refer to https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions for a description of how a PR is supposed to be merged. |
@Ericson2314 : Ah, yes, me setting the "merge me" label wasn't instructing you to do a merge commit, but this is a command to Mergify to rebase+merge (with a 2 day delay). No great harm done, but for the sake of a linear history rebase+merge (e.g. in your case with clean commits) or squash+merge are preferred. |
Ah sorry about that, yes I did indeed misinterpet the label. |
See each commit for details. There are no public interface changes, just shuffling around private details.