-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify default exe extension on wasm32 to be .wasm #8633
Conversation
4454816
to
5e2cdeb
Compare
@TerrorJack thanks for the patch and congrats with getting the necessary approvals! The procedure now is that you apply one of the two merge-me labels to hand it over to the bot. In my opinion, this patch could be improved with a test. But I don't want to hold it hostage to a test. |
@ulysses4ever Thanks for the reminder! Re label: it seems I'm not a contributor to this repo, so I don't see the option to edit labels on this PR. If I can be granted contributor right or someone adds a Re test: another MR in GHC (!9533) needs to land, and then it may be possible to test it meaningfully. |
Ah, good to know! @Mikolaj will see to the label/permissions business, I hope |
In the meantime, I added the merge-me label. |
@TerrorJack: please kindly receive the Triage authority for our humble repo. |
The honor is mine :) |
Specify default exe extension on wasm32 to be .wasm, following the convention in other WebAssembly toolchains.
5e2cdeb
to
ed407b1
Compare
This could have a test? It seems to me that Cabal integration with wasm should be tested somehow |
@jneira I can think of a simple E2E test that invokes By any chance I'd be happy to add such a test if the idea sounds good to you; I'm working on unblocking wasm CI for GHC 9.6 release and after that I can revisit this issue. |
It sounds great. I guess some e2e test for wasm would be needed sooner or later and well, maybe this pr is not the best place. Cabal tests in ci uses the default ghc, yeah, but i think there are guards to run tests conditionally on ghc version and these tests will need it. |
This PR changes default exe extension on wasm32 to be
.wasm
, following convention of other WebAssembly toolchains. This is a part of the effort tracked in https://gitlab.haskell.org/ghc/ghc/-/issues/22594.Please include the following checklist in your PR: