cabal init -i should sanitize suggested package name (fix #8404) #8561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilypi
reviewed
Oct 29, 2022
|
Well, tests are failing currently, so I'll have to take a look. |
b04c6e7 to
76f91dd
Compare
fc8e309 to
26a3f78
Compare
|
Ready for review! |
emilypi
approved these changes
Nov 9, 2022
ffaf1
reviewed
Nov 9, 2022
ffaf1
approved these changes
Nov 9, 2022
|
@mergify backport 3.8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2022
* cabal init -i should sanitize suggested package name (fix #8404) * fix existing tests * fix more tests (golden) * fix more tests (generators, simple) * add regression test * add changelog Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e714824)
alexbiehl
pushed a commit
to alexbiehl/cabal
that referenced
this pull request
Dec 15, 2022
… (haskell#8561) * cabal init -i should sanitize suggested package name (fix haskell#8404) * fix existing tests * fix more tests (golden) * fix more tests (generators, simple) * add regression test * add changelog Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An easy fix for #8404: cabal init -n already does the right thing, so this PR merely moves some code around so that cabal init -i can benefit from it too.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!