Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose BuildFlags and ClientHaddockFlags #8353

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Conversation

kokobd
Copy link
Collaborator

@kokobd kokobd commented Aug 10, 2022

This will fix #8351


Please include the following checklist in your PR:

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you find anything else, feel free to add while the PR is still not merged.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 10, 2022

FYI: CI is borked right now (#8356), so the error probably has nothing to do with this PR.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 11, 2022

Let me rebase to see if the recent CI workaround unblocks your testing.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 11, 2022

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2022

rebase

✅ Branch has been successfully rebased

@kokobd
Copy link
Collaborator Author

kokobd commented Aug 12, 2022

This might be ready in my mind.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 12, 2022

Splendid. Let's wait for the mandatory second review.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change, makes total sense, so I'm on board. Thank you!

@ulysses4ever
Copy link
Collaborator

Someone has to apply the squash+merge_me label now.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 12, 2022

@kokobd: I've granted you Triage authorization so that you can set the squash+merge_me (or merge_me) label on this PR and behold the mergifyIO magic (which takes 2 todays to unfold, in order to give people time to comment).

@kokobd kokobd added the squash+merge me Tell Mergify Bot to squash-merge label Aug 13, 2022
@Mikolaj
Copy link
Member

Mikolaj commented Aug 15, 2022

CI seems to be broken. Let me rebase to verify if our recent partial fixes help.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 15, 2022

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2022

rebase

✅ Branch has been successfully rebased

@kokobd
Copy link
Collaborator Author

kokobd commented Aug 16, 2022

what a strange error:
Screen Shot 2022-08-16 at 10 06 23

@Mikolaj
Copy link
Member

Mikolaj commented Aug 16, 2022

what a strange error:

Yes, I think something broke in our CI infrastructure. Due to that mergify can't merge automatically, so let me merge manually.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 16, 2022

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2022

rebase

☑️ Nothing to do

  • -closed [:pushpin: rebase requirement]
  • any of:
    • #commits-behind>0 [:pushpin: rebase requirement]
    • -linear-history [:pushpin: rebase requirement]

@Mikolaj Mikolaj merged commit 3e9e6c3 into haskell:master Aug 16, 2022
@Mikolaj
Copy link
Member

Mikolaj commented Aug 16, 2022

@kokobd: thank you!

@kokobd
Copy link
Collaborator Author

kokobd commented Sep 13, 2022

@mergify backport 3.8

Then let's backport this too, so that cabal-hoogle can work with cabal 3.8

@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2022

backport 3.8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 13, 2022
kokobd added a commit that referenced this pull request Sep 14, 2022
mergify bot added a commit that referenced this pull request Sep 14, 2022
Expose BuildFlags and ClientHaddockFlags (backport #8353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal-install BuildFlags is not exported?
3 participants