-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose BuildFlags and ClientHaddockFlags #8353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If you find anything else, feel free to add while the PR is still not merged.
FYI: CI is borked right now (#8356), so the error probably has nothing to do with this PR. |
Let me rebase to see if the recent CI workaround unblocks your testing. |
@mergify rebase |
✅ Branch has been successfully rebased |
This might be ready in my mind. |
Splendid. Let's wait for the mandatory second review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny change, makes total sense, so I'm on board. Thank you!
Someone has to apply the |
@kokobd: I've granted you Triage authorization so that you can set the squash+merge_me (or merge_me) label on this PR and behold the mergifyIO magic (which takes 2 todays to unfold, in order to give people time to comment). |
CI seems to be broken. Let me rebase to verify if our recent partial fixes help. |
@mergify rebase |
✅ Branch has been successfully rebased |
Yes, I think something broke in our CI infrastructure. Due to that mergify can't merge automatically, so let me merge manually. |
@mergify rebase |
☑️ Nothing to do
|
@kokobd: thank you! |
@mergify backport 3.8 Then let's backport this too, so that cabal-hoogle can work with cabal 3.8 |
✅ Backports have been created
|
(cherry picked from commit 3e9e6c3)
(cherry picked from commit 3e9e6c3)
Expose BuildFlags and ClientHaddockFlags (backport #8353)
This will fix #8351
Please include the following checklist in your PR: