Expose cabal-install lib, remove dogfooding, expose cabal-install-solver as own lib, enable HPC coverage reporting. #7358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgaz
reviewed
Apr 14, 2021
fgaz
reviewed
Apr 14, 2021
21cfe3f to
c431c69
Compare
|
Could you squash the commits that do the same thing (eg. Setup.hs for cabal-install-solver → separate cabal-install-solver)? |
|
Sure i'll restructure these and rebase tomorrow 👍 |
emilypi
added a commit
that referenced
this pull request
Apr 23, 2021
* Add missing bootstrap plans * Add changelog entry for #7358
825fa86 to
db2a099
Compare
|
This would be massively useful to me. |
7bf6fb1 to
ceb3040
Compare
* Add Setup.hs for `cabal-install-solver` * Update `cabal.project` pkg path for `cabal-install-solver`
* Strips away dogfooding framework and zinza templates * Splits out tests into targets by as a function of running time * Delete TESTING.md as it no longer applies * Bump cabal-install.cabal to its dev template settings (base >= 4.10, Cabal 2.2) * Remove Paths_cabal_install (blocks HPC generation) * Add `long-tests` target to split out unit-tests and long-running DVCS tests.
* Changes needed for GenValidate and release.py to accommmodate new solver dependency * Bumps bootstrap plans to modern GHC versions * Update `validate.sh` and `release.py` to accommodate new solver dep. * Update `Makefile` targets
c5825c8 to
12daef5
Compare
|
@fgaz okay - comments should be addressed, and I'll merge on green, following up with a PR with updates to the release checklist. The release checklist in particular needs to detail how to update CI, which i'll add as well. I'll do one more pass to see if anything stands out, and then I think we're good to merge. |
3f7f428 to
0b8d3f8
Compare
0b8d3f8 to
7d1fd6b
Compare
This was
linked to
issues
May 3, 2021
This was
linked to
issues
May 3, 2021
fgaz
approved these changes
May 3, 2021
This was referenced Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #7344 (comment), this PR does the following:
cabal-installas a library, bumping thecabal-installcabal version to 2.2, and removing the dogfooding framework surroundingcabal-installto facilitate easier testing.cabal-install-solverout to its own directory, and treats it as its own separate project. Addresses Exposecabal.projectin library component? #6090, Expose cabal.project.freeze parsing in the Cabal library #7224, and Split dependency solver into a library #3781cabal-install-solver-dslmodule into the test modules, and incorporate it into its own test target. Splits out unit tests from long-running tests. Also adds proper subcomponent coverage masking so we can finally generate baseline coverage reports forcabal-install.TODO:
Fixes:
cabal.projectin library component? #6090Baseline report:
cabal-install-baseline-coverage.zip
CC @fgaz @phadej @ptkato