Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Paths module using zinza template #6984

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jul 22, 2020

This breaks absolute and relocatable variants. Let me see if we have any tests for them (maybe on windows).

@angerman
Copy link
Collaborator

O_o

@phadej
Copy link
Collaborator Author

phadej commented Jul 22, 2020

@angerman

O_o

!_?

@phadej
Copy link
Collaborator Author

phadej commented Jul 22, 2020

This is a step cleaning up the implementation of Paths_<pkg> module generation, so it can be more easily changed (e.g. to achieve #4097). Concatenating strings manually is not 2020.

@phadej phadej force-pushed the zinza-paths branch 4 times, most recently from 76a9254 to 64f33bb Compare July 22, 2020 19:08
@angerman
Copy link
Collaborator

I only read

This breaks absolute and relocatable variants.

and was confused. I still believe the Paths module should not exist, but I'm hard pressed to offer a sensible alterntive.

@phadej phadej merged commit a2a6bd4 into haskell:master Jul 23, 2020
@phadej phadej deleted the zinza-paths branch July 23, 2020 08:08
@phadej phadej added this to the 3.6.0.0-rc1 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants