Backporting to 3.0 #6425
Merged
Backporting to 3.0 #6425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are only supported properly starting with cabal-version:3.0 (which has been enforced by Hackage as well -- via this very patch). See haskell#6033 for details
I.e. don’t rebuild everything when a ghc flag that affects how error messages are presented is added.
On Windows dropExeExtension doesn't actually drop the exe extension.
We have
splitExtension "foo.exe" == ("foo", ".exe")
but the code is expecting just "exe" for the extension field.
Among other things this makes guessToolFromGhcPath behave
unexpectedly. Since takeVersionSuffix can't see past the extension the
`null suf` case in mkGuesses will trigger which causes the versioned
program path candidates to not be looked for.
And doctesting
This is very useful for validate.sh script, We should be aware of which tests are skipped. Perfectly, SKIP should tell a reason.
… is compiled with This makes e.g. LibV09 test work properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hvr