Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for 'new-test' command #6058

Merged
merged 1 commit into from
May 26, 2019

Conversation

erikd
Copy link
Member

@erikd erikd commented May 26, 2019

Suggest adding '--enable-tests'. [ci skip]


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@erikd erikd requested a review from dcoutts May 26, 2019 07:37
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, or perhaps better to recommend the equivalent in the cabal.project[.local].

@erikd
Copy link
Member Author

erikd commented May 26, 2019

Hmm, yeah. For projects with a single cabal this is the right message, but maybe it should be changed for multi cabal file projects.

@erikd erikd force-pushed the erikd/enable-tests-error-msg branch from ba272bb to 382a09f Compare May 26, 2019 21:33
Suggest adding '--enable-tests'. [ci skip]
@erikd erikd force-pushed the erikd/enable-tests-error-msg branch from 382a09f to 0ce6ba9 Compare May 26, 2019 22:49
@erikd
Copy link
Member Author

erikd commented May 26, 2019

Had private IM discussion with @dcoutts about this issue and this is the change we came to agree on.

@erikd erikd merged commit 9c31d9c into haskell:master May 26, 2019
@erikd erikd deleted the erikd/enable-tests-error-msg branch May 26, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants