-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cabal: Honour -working-dir flag when running test executables #10725
base: master
Are you sure you want to change the base?
Conversation
Excellent, thanks @mpickering. Is there a similar bug in the code for running benchmarks? IIRC that code is very similar. |
Benchmarks look to be fine. I'll extend the test anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Needs only a merge label now after two reviews. |
A simple fix to run the test executable in the `-working-dir`. Fixes haskell#10704
@mpickering: would you like to set the merge label? it's a way of saying you don't want to add anything else to the PR (label needs-review only says it's ready enough to be reviewed). |
A simple fix to run the test executable in the
-working-dir
.Fixes #10704
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.