Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows Aarch64 #10705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

GulinSS
Copy link

@GulinSS GulinSS commented Jan 3, 2025

See details: https://gitlab.haskell.org/ghc/ghc/-/issues/24603#note_565835

The patch adds support Aarch64 builds at Windows platform.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:


Asking for an exemption for tests.
I am not sure about QA notes. Should I add a link to the compiler which can be used to test it? Temporal link is here.

@fgaz
Copy link
Member

fgaz commented Jan 5, 2025

Looks good, but please use template A and write a changelog entry, since this change is relevant to users

@GulinSS GulinSS changed the title Add support for Windows ARM Add support for Windows Aarch64 Jan 5, 2025
@GulinSS GulinSS force-pushed the wip/T24603 branch 2 times, most recently from 0829693 to 0a2e5ac Compare January 5, 2025 11:06
@GulinSS GulinSS force-pushed the wip/T24603 branch 2 times, most recently from b406f05 to 7f7451f Compare January 10, 2025 09:23
@GulinSS
Copy link
Author

GulinSS commented Jan 10, 2025

Forgot one item with c_GetModuleFileName for paths generation.


Hm... What is wrong with the check?

@fgaz
Copy link
Member

fgaz commented Jan 10, 2025

PathsModule is autogenerated, you have to modify Z.hs and run cabal run gen-paths-module iirc

Co-authored-by: Cheng Shao <terrorjack@type.dance>
@GulinSS
Copy link
Author

GulinSS commented Jan 11, 2025

@fgaz thanks for the pointing!

I was needed to manually remove file pathes defined by TEMPLATE_MACROS and TEMPLATE_PATHS at Makefile and then just run

make templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants