Incremental decoding for containers #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e71c00c to
e6c8228
Compare
The default interface is meant to work with lazy I/O. Unfortunately we lazy I/O is not always available. This PR introduces a new low-level primitive for decoding the blocks of container so that more input can be fed incrementally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default interface is meant to work with lazy I/O. Unfortunately lazy I/O is not always easily available.
This PR introduces new low-level primitives for decoding containers for which input can be fed incrementally without necessarily relying on lazy I/O. Yet, lazy I/O is still perfectly supported.
The idea is very similar to binaries
Decoder. With the key difference that the Blocks structure interleaves producing of results and consuming more bytes. This allows us to feed more bytes incrementally - even if only coming from a lazy ByteString.I am using this change in production to stream huge containers from S3 using Amazonka.