Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax bounds: servant, servant-server #28

Merged

Conversation

Tristano8
Copy link
Contributor

@Tristano8 Tristano8 commented Jun 29, 2023

No description provided.

@Tristano8 Tristano8 force-pushed the relax-bounds-servant-server branch from 7128054 to de01ba1 Compare July 4, 2023 00:40
@Tristano8 Tristano8 force-pushed the relax-bounds-servant-server branch from de01ba1 to 4998d66 Compare July 4, 2023 01:40
@Tristano8
Copy link
Contributor Author

Ci failures are caused by haskell-servant/servant#1691

Once haskell/aeson#1048 is merged and metadata revisions made for servant this should pass

@ysangkok
Copy link
Contributor

ysangkok commented Jul 5, 2023

Not all failures are caused by the aeson upgrade. Failures for the oldest builds are caused by lax lower bounds on GHC for servant (could be checked just by limiting base, though it is a bit weird):

Building library for servant-0.20..

src/Servant/Links.hs:10:14: error:
    Unsupported extension: QuantifiedConstraints

We should probably also raise the lower bound for servant, but since the builds will never work, they should be removed. Seems to me that the oldest GHC with QuantifiedConstraints is 8.6.

@ysangkok ysangkok merged commit 28faa2b into haskell-servant:master Jul 8, 2023
@ocharles
Copy link
Contributor

ocharles commented Aug 1, 2023

Could we get a Hackage release with this, or a Hackage revision? Thanks!

@ysangkok
Copy link
Contributor

ysangkok commented Aug 1, 2023

@maksbotan I don't have the maintainer bit on this package, would it be possible for you to bump it?

@Bodigrim
Copy link

As a Hackage trustee I made a revision: https://hackage.haskell.org/package/servant-lucid-0.9.0.6/revisions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants