The connectDPI function can now consume fields from ConnectionCreateParams. #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
connectDPI
was passing anullPtr
in place ofConnectionCreateParams
, which meant there was no way to passConnectionCreateParams
toconnectDPI
. This PR modifiesconnectDPI
to accept values fromAdditionalConnectionParams
(the fields which are part ofConnectionCreateParams
) and pass them toconnectDPI
.For demonstration purposes, I have included
authMode
inAdditionalConnectionParams
. More fields fromConnectionCreateParams
can be added toAdditionalConnectionParams
in the future as needed.A design consideration arises from the fact that
AdditionalConnectionParams
contains fields for bothConnectionCreateParams
andPoolCreateParams
. Please let me know if this design approach is acceptable or if modifications are recommended. Thank you!@apkhandkar @dmjio