Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The connectDPI function can now consume fields from ConnectionCreateParams. #52

Merged

Conversation

tusharad
Copy link
Contributor

@tusharad tusharad commented Jan 3, 2025

Previously, connectDPI was passing a nullPtr in place of ConnectionCreateParams, which meant there was no way to pass ConnectionCreateParams to connectDPI. This PR modifies connectDPI to accept values from AdditionalConnectionParams (the fields which are part of ConnectionCreateParams) and pass them to connectDPI.

For demonstration purposes, I have included authMode in AdditionalConnectionParams. More fields from ConnectionCreateParams can be added to AdditionalConnectionParams in the future as needed.

A design consideration arises from the fact that AdditionalConnectionParams contains fields for both ConnectionCreateParams and PoolCreateParams. Please let me know if this design approach is acceptable or if modifications are recommended. Thank you!

@apkhandkar @dmjio

@dmjio dmjio merged commit 1b97e3e into haskell-oracle:master Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants