Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve extension identifiers from manifest #807

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Oct 12, 2021

This pulls the extension identifiers from the package.json file using the extension context instead of hard coding them. It also moves the appInsightsKey to the package.json file.

Closes #786

@jpogran jpogran force-pushed the resolve-extension-identifiers branch from cab39fd to ed0bf20 Compare October 12, 2021 16:22
@jpogran jpogran marked this pull request as ready for review October 12, 2021 16:22
@jpogran jpogran self-assigned this Oct 12, 2021
@jpogran jpogran requested a review from a team October 12, 2021 16:23
@jpogran jpogran added the ci Continuous integration/delivery related label Oct 12, 2021
@jpogran jpogran marked this pull request as draft October 12, 2021 23:42
@radeksimko radeksimko marked this pull request as ready for review October 13, 2021 09:15
radeksimko
radeksimko previously approved these changes Oct 13, 2021
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth also addressing these hard-coded extension IDs?

const ext = vscode.extensions.getExtension('hashicorp.terraform');

const ext = vscode.extensions.getExtension('hashicorp.terraform');

@jpogran
Copy link
Contributor Author

jpogran commented Oct 13, 2021

I misunderstood the original ticket @radeksimko made, and thought the requirement was removing vscode.extensions.getExtension from the tests as well as the main activate function. This would be difficult to do in general without a lot of work, and impossible in the end-to-end tests we have. Radek meant removing the hardcoded ID now, and look into improving the tests at a later date.

radeksimko
radeksimko previously approved these changes Oct 13, 2021
@jpogran jpogran force-pushed the resolve-extension-identifiers branch from 268e2e3 to 91a1ce8 Compare October 13, 2021 15:25
@jpogran jpogran marked this pull request as draft October 13, 2021 15:33
This pulls the extension identifiers from the package.json file using the extension context instead of hard coding them. It also moves the appInsightsKey to the package.json file.

This also bumps minimum vscode engine required to 1.55 to use the `context.extension` method.
@jpogran jpogran force-pushed the resolve-extension-identifiers branch from 91a1ce8 to dbd6dab Compare October 13, 2021 15:37
@jpogran jpogran marked this pull request as ready for review October 13, 2021 15:43
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jpogran jpogran merged commit 00a93eb into main Oct 13, 2021
@jpogran jpogran deleted the resolve-extension-identifiers branch October 13, 2021 15:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid hard-coding extension ID except in package.json
2 participants