-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve extension identifiers from manifest #807
Conversation
cab39fd
to
ed0bf20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth also addressing these hard-coded extension IDs?
vscode-terraform/src/test/helper.ts
Line 26 in d79aeca
const ext = vscode.extensions.getExtension('hashicorp.terraform'); |
const ext = vscode.extensions.getExtension('hashicorp.terraform'); |
14e1e65
to
268e2e3
Compare
I misunderstood the original ticket @radeksimko made, and thought the requirement was removing |
268e2e3
to
91a1ce8
Compare
This pulls the extension identifiers from the package.json file using the extension context instead of hard coding them. It also moves the appInsightsKey to the package.json file. This also bumps minimum vscode engine required to 1.55 to use the `context.extension` method.
91a1ce8
to
dbd6dab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This pulls the extension identifiers from the package.json file using the extension context instead of hard coding them. It also moves the appInsightsKey to the package.json file.
Closes #786