(maint) Set syntax and format style guidelines #745
Conversation
5a73d95 to
3b10c91
Compare
Update eslint and prettier packages and add style and format guidelines to editorconfig and VS Code worskpace settings file. This aligns to company standards for code style and formatting and ensures consistent spacing, line endings, and file encodings. This does not enable any new eslint rules, as that is out of scope for this line of work. This also configures VS Code to use prettier and eslint for all typescript, javascript and json formatting and use eslint and prettier to enforce guidelines.
There was a problem hiding this comment.
For the CDK for Terraform we chosed to use the Prettier defaults without any adjustments to leave discussions about preferred code style to those working on Prettier.
I personally am happy with most things as long as they're consistent in the codebase, so me mentioning this is more of a sidenote 😄 If you e.g. like ' more than " go for it – you will have to read that code daily 😄
|
Thanks @ansgarm for the review! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Update eslint and prettier packages and add style and format guidelines to editorconfig and VS Code worskpace settings file.
This aligns to company standards for code style and formatting and ensures consistent spacing, line endings, and file encodings. This does not enable any new eslint rules, as that is out of scope for this line of work.
This also configures VS Code to use prettier and eslint for all typescript, javascript and json formatting and use eslint and prettier to enforce guidelines.