Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syntax for object and tuple structural types #428

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Add syntax for object and tuple structural types #428

merged 1 commit into from
Jul 2, 2020

Conversation

aeschright
Copy link
Contributor

Fixes #391

@aeschright aeschright requested review from paultyng and radeksimko July 2, 2020 00:28
radeksimko
radeksimko approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that fixes the bug.

paultyng
paultyng approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As an aside, is there anyway to test tmlanguage files against source files and assert the expected tokenization? Not a big deal, but was just curious if you had encountered anything like that we could add down the road.

@aeschright
Copy link
Contributor Author

I haven't run across anything, in general it seemed like tips for implementing new syntaxes were pretty heavy on the "and then you manually hammer on it until something works".

@aeschright aeschright merged commit 4df64eb into master Jul 2, 2020
@aeschright aeschright deleted the types-syntax branch July 2, 2020 18:16
aeschright added a commit that referenced this pull request Jul 2, 2020
@aeschright
Update changelog for #428
6f72b6b
@alexjurkiewicz alexjurkiewicz mentioned this pull request Jul 2, 2020
Closed
@aeschright aeschright mentioned this pull request Jul 11, 2020
Closed
@ghost
Copy link

ghost commented Aug 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equals symbol in variable type literals breaks syntax highlighting
3 participants
@aeschright @radeksimko @paultyng