Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws auth fixes #9825

Merged
merged 12 commits into from
Aug 25, 2020
Merged

Aws auth fixes #9825

merged 12 commits into from
Aug 25, 2020

Conversation

sgmiller
Copy link
Collaborator

Rebuilt changes by cherry-picking from the two major branches from the point releases. Should be identical to what was previously reviewed.

@sgmiller sgmiller requested a review from calvn August 25, 2020 21:23
@@ -2,6 +2,11 @@ package awsauth

import (
"context"
"errors"
"github.com/hashicorp/vault/sdk/helper/strutil"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move down?

Copy link
Collaborator Author

@sgmiller sgmiller Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(shakes fist at Goland)

@sgmiller sgmiller requested a review from calvn August 25, 2020 22:09
Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We need to backport this back to the release branches since it contains additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants