-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aws auth fixes #9825
Aws auth fixes #9825
Conversation
@@ -2,6 +2,11 @@ package awsauth | |||
|
|||
import ( | |||
"context" | |||
"errors" | |||
"github.com/hashicorp/vault/sdk/helper/strutil" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(shakes fist at Goland)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We need to backport this back to the release branches since it contains additional changes.
Rebuilt changes by cherry-picking from the two major branches from the point releases. Should be identical to what was previously reviewed.