Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated AWS client instantiations #8060

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

tyrannosaurus-becks
Copy link
Contributor

This PR is to replace deprecated AWS client instantiations at all points where they exist in Vault. This PR has some overlap with #7738, but updates the client in more places. It doesn't really matter which of these gets merged first, probably best to merge whichever is ready first.

I ran acceptance tests locally with a valid AWS key and secret to verify that nothing was broken. I can't post the output of all tests because some of it may be sensitive. However, all tests passed and none were skipped as a result of this call:

tbex@pop-os:~/go/src/github.com/hashicorp/vault/builtin/logical/aws$ go test -v ./...

Also, the s3 tests were run and passed and are safe to post:

tbex@pop-os:~/go/src/github.com/hashicorp/vault/physical/s3$ go test -v ./...
=== RUN   TestDefaultS3Backend
--- PASS: TestDefaultS3Backend (6.70s)
=== RUN   TestS3BackendSseKms
--- PASS: TestS3BackendSseKms (6.42s)
PASS
ok  	github.com/hashicorp/vault/physical/s3	13.128s

@tyrannosaurus-becks tyrannosaurus-becks merged commit 6582348 into master Jan 9, 2020
@tyrannosaurus-becks tyrannosaurus-becks deleted the always-use-session-new-for-aws branch January 9, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants