Replace deprecated AWS client instantiations #8060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to replace deprecated AWS client instantiations at all points where they exist in Vault. This PR has some overlap with #7738, but updates the client in more places. It doesn't really matter which of these gets merged first, probably best to merge whichever is ready first.
I ran acceptance tests locally with a valid AWS key and secret to verify that nothing was broken. I can't post the output of all tests because some of it may be sensitive. However, all tests passed and none were skipped as a result of this call:
Also, the s3 tests were run and passed and are safe to post: