Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL support for PostgreSQL in the Database secrets engine #5963

Closed

Conversation

eirslett
Copy link

Related to #3191.

This is an attempt at adding support for providing a custom server CA and client public/private key pair, for encrypted communication between Vault and PostgreSQL.

This PR is dependent on a patch to the Go client library for PostgreSQL lib/pq#818 to be merged.

What do you think about this solution?

@jefferai
Copy link
Member

jefferai commented Dec 17, 2018

Edit: looked at the PQ issue, not this.

@eirslett
Copy link
Author

eirslett commented Dec 18, 2018

Judging by the previous (now-edited) comment, this might seem somewhat like the "right approach" then?

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 15, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for your PR regarding this!

We actually are in the process of deprecating the Postgres secrets engine located at builtin/logical/postgres because it's been replaced by the Postgres database engine. The docs mark this engine as deprecated, but we haven't removed it from the code yet in the interest of maintaining backwards compatibility (for now).

If there is a way to add this feature to the database secrets engine, I would support that instead! :-)

@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Mar 24, 2020
@tyrannosaurus-becks tyrannosaurus-becks removed their assignment May 28, 2020
@ncabatoff
Copy link
Collaborator

Hi @eirslett,

I agree with @tyrannosaurus-becks: thank you for the PR, but we're not making further non-critical changes to the deprecated version of the postgres secrets database engine.

@ncabatoff ncabatoff closed this Jun 5, 2020
@binlab
Copy link
Contributor

binlab commented Feb 15, 2021

Hi, @eirslett since a lib/pq#818 merged, could you please make your changes for the new Postgres secrets engine? Thanks!

@eirslett
Copy link
Author

@binlab I'm not involved a lot with Vault lately, it's better if somebody with more updated knowledge of the code can look at it! The lib/pq library must be released with a new version first, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants