Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateUser deadlock fix #3761

Merged
merged 3 commits into from
Jan 8, 2018
Merged

CreateUser deadlock fix #3761

merged 3 commits into from
Jan 8, 2018

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Jan 8, 2018

Fixes #2973

@calvn calvn requested a review from jefferai January 8, 2018 16:02
@jefferai
Copy link
Member

jefferai commented Jan 8, 2018

Oooooooooooooooh

@jefferai
Copy link
Member

jefferai commented Jan 8, 2018

I think this is likely okay, but does anyone else think the lock swaperoo will lead to issues?

@calvn calvn changed the title Unlock the lock on CreateUser for Close call CreateUser deadlock fix Jan 8, 2018
@calvn calvn merged commit dc186b6 into master Jan 8, 2018
@calvn calvn deleted the mongodb-close-deadlock branch January 8, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvn @jefferai