Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that a CSR specifies IP SANs before checking whether it's allowed #2574

Merged
merged 3 commits into from
Apr 13, 2017
Merged

Verify that a CSR specifies IP SANs before checking whether it's allowed #2574

merged 3 commits into from
Apr 13, 2017

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Apr 6, 2017

Fixes #2553

@jefferai jefferai added this to the 0.7.1 milestone Apr 6, 2017
@jefferai jefferai requested a review from chrishoffman April 6, 2017 20:14
chrishoffman
chrishoffman approved these changes Apr 11, 2017
View reviewed changes
Copy link
Contributor

@chrishoffman chrishoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test case but the change looks good to me.

@jefferai jefferai merged commit f92b173 into master Apr 13, 2017
@jefferai jefferai deleted the issue-2553 branch April 13, 2017 17:40
chrishoffman pushed a commit that referenced this pull request Apr 17, 2017
Merge remote-tracking branch 'oss/master' into type-string-slice
35300a7 
* oss/master: (43 commits)
  Bump deps
  Update SSH docs to indicate deprecation of dynamic key type
  Bump Go version in Travis
  changelog++
  Bump go version to 1.8.1
  Consider new bounds as a criteria to allow role creation (#2600)
  Update 404.html.md (#2594)
  Add some extra documentation around ssh-keygen -L to see signed cert info.
  changelog++
  Respect the configured address's path in the client (#2588)
  changelog++
  Verify that a CSR specifies IP SANs before checking whether it's allowed (#2574)
  minor docs update
  changelog++
  Update AES-GCM verification text
  changelog++
  implement a no_store option for pki roles (#2565)
  Remove superfluous/misleading comments around some listener options
  Update SSH CA documentation
  Add press-kit
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishoffman chrishoffman chrishoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jefferai @chrishoffman