Backport of api/seal-status: fix deadlock when namespace is set on seal-status calls into release/1.15.x #23881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23861 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
🚨
The person who merged in the original PR is:
@jasonodonnell
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
PR #10725 introduced a change to support namespaces in vault status requests but introduced a deadlock on calls to
sys/seal-status
when namespaces are included.When requests have a namespace configured the handler routes the request through
switchedLockHandleRequest
and holds the read statelock for the duration of the request:vault/vault/request_handling.go
Lines 530 to 533 in 550c99a
I've added a locking arg so the caller can decide if the statelock needs to be grabbed or not.
Overview of commits