Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.11.x: AD FS namespace OIDC bug fix #19460 #19694

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

hellobontempo
Copy link
Contributor

Backport for #19460

* the fix

* changelog

* clair fix

* add test

* update changelog

* clarify comment

* remove state from paramsFor completely, update tests

* Revert "remove state from paramsFor completely, update tests"

This reverts commit bea042f.

* add tests with skips until not flaky

---------

Co-authored-by: clairebontempo@gmail.com <clairebontempo@gmail.com>
Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
@hellobontempo hellobontempo added ui backport bug Used to indicate a potential bug labels Mar 23, 2023
@hellobontempo hellobontempo added this to the 1.11.9 milestone Mar 23, 2023
@hellobontempo hellobontempo enabled auto-merge (squash) March 23, 2023 06:45
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellobontempo hellobontempo merged commit 85fcea4 into release/1.11.x Mar 23, 2023
@hashishaw hashishaw deleted the ui/backport-pr-19460-1.11.x branch March 23, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants