Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PKI documentation to clear up PKCS8 marshalling behavior #17080

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Update PKI documentation to clear up PKCS8 marshalling behavior #17080

merged 1 commit into from
Sep 9, 2022

Conversation

stevendpclark
Copy link
Contributor

  • Update the documentation in regards to the private_key_format argument only controls the behavior of the private_key response field and does not modify the encoding of the private key within the pem_bundle.

@stevendpclark stevendpclark requested review from kitography, cipherboy and a team September 9, 2022 15:11
@stevendpclark
Update PKI documentation to clear up PKCS8 marshalling behavior
535a4fb 
 - Update the documentation in regards to the private_key_format
   argument only controls the behavior of the private_key response field
   and does not modify the encoding of the private key within the
   pem_bundle.
@stevendpclark stevendpclark force-pushed the docs/pki-format-private-key branch from f327986 to 535a4fb Compare September 9, 2022 15:22
@stevendpclark stevendpclark merged commit b7f4b6d into main Sep 9, 2022
This was referenced Sep 9, 2022
Merged
Merged
@stevendpclark
Copy link
Contributor Author

Thanks all!

stevendpclark added a commit that referenced this pull request Sep 9, 2022
@stevendpclark
Update PKI documentation to clear up PKCS8 marshalling behavior (#17080)
d3bc505 
- Update the documentation in regards to the private_key_format
   argument only controls the behavior of the private_key response field
   and does not modify the encoding of the private key within the
   pem_bundle.
stevendpclark added a commit that referenced this pull request Sep 9, 2022
@hc-github-team-secure-vault-core @stevendpclark
Update PKI documentation to clear up PKCS8 marshalling behavior (#17080…
44422d0 
…) (#17081)

- Update the documentation in regards to the private_key_format
   argument only controls the behavior of the private_key response field
   and does not modify the encoding of the private key within the
   pem_bundle.

Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
@stevendpclark stevendpclark deleted the docs/pki-format-private-key branch September 9, 2022 15:58
@stevendpclark stevendpclark mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schultz-is schultz-is schultz-is approved these changes

@cipherboy cipherboy cipherboy approved these changes

@kitography kitography Awaiting requested review from kitography

@taoism4504 taoism4504 Awaiting requested review from taoism4504

Assignees
No one assigned
Labels
docs pr/no-changelog secret/pki
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevendpclark @cipherboy @schultz-is