Provide 'sys/step-down' and 'vault step-down' #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This endpoint causes the node it's hit to step down from active duty. It's a noop if the node isn't active or not running in HA mode. The node will wait one second before attempting to reacquire the lock, to give other nodes a chance to grab it. Fixes #1093
| // to perform any further operations. | ||
| func (c *Core) stepDownAndSeal(token string, seal bool) (retErr error) { | ||
| if seal { | ||
| defer metrics.MeasureSince([]string{"core", "seal"}, time.Now()) |
There was a problem hiding this comment.
I would just move this into the appropriate methods above to make it cleaner
There was a problem hiding this comment.
I thought about that; I was attempting to avoid copypasta since much of the logic is the same. But there's enough different that it can go either way.
| return logical.ErrPermissionDenied | ||
| } | ||
|
|
||
| c.manualStepDownCh <- struct{}{} |
There was a problem hiding this comment.
We should guard this with a default case in case there is no listener on the other side to avoid blocking.
|
One minor comment, LGTM |
jefferai
added a commit
that referenced
this pull request
Mar 3, 2016
Provide 'sys/step-down' and 'vault step-down'
rajanadar
added a commit
to rajanadar/VaultSharp
that referenced
this pull request
Aug 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint causes the node it's hit to step down from active duty.
It's a noop if the node isn't active or not running in HA mode. The node
will wait one second before attempting to reacquire the lock, to give
other nodes a chance to grab it.
Fixes #1093